openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
130 stars 80 forks source link

add golangci-lint errcheck warning #1647

Closed chmouel closed 5 months ago

chmouel commented 6 months ago

we were getting this warning:

WARN [config_reader] The configuration option `linters.errcheck.exclude`
is deprecated, please use `linters.errcheck.exclude-functions`.

so removing .errcheck.txt and adding the functions to the .golangci.yml

add a comment to the go code to explain what the function does and launch golangci-lint to make sure it's all good.

Changes

Submitter Checklist

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.11%. Comparing base (2053951) to head (4f330b2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1647 +/- ## ======================================= Coverage 64.11% 64.11% ======================================= Files 140 140 Lines 10871 10871 ======================================= Hits 6970 6970 Misses 3385 3385 Partials 516 516 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.