codecov[bot]
commented
5 months ago Codecov Report
Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 64.13%. Comparing base (
28178ab) to head (cf35b5f). Report is 1 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/pipelineascode/match.go | 58.33% | 4 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1652 +/- ## ========================================== + Coverage 64.12% 64.13% +0.01% ========================================== Files 141 141 Lines 10878 10878 ========================================== + Hits 6975 6977 +2 + Misses 3387 3385 -2 Partials 516 516 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
piyush-garg
savitaashture
We were always getting the first one of the pipelinerun, i thought the filtering was already done and it would always be only one PipelineRun but we re-fetch everything on resolve.Resolve, so redoing the filtering properly.
Improve e2e to make sure it handles this properly to explicit test the proper PipelineRun.
Refactor a bit the gitea tests for GitOPS commands to be in its own file. g# Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).