Closed chmouel closed 5 months ago
Attention: Patch coverage is 94.44444%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 64.24%. Comparing base (
df22211
) to head (59bdf9c
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
pkg/matcher/annotation_matcher.go | 93.75% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/retest
/test go-testing
By changing the log level of some of the logs from Info or Warn to Debug
admin can always configure the debug level to show if they want, https://pipelinesascode.com/docs/install/settings/#logging-configuration
some docs links issues fix as well
Fixes #1658
Changes
Submitter Checklist
[ ] π Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] β½ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] β¨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] π If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] π§ͺ While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] π If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] π If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).