Setup pac config syncer

[sm43]

this setups a configmap syncer which uses informer and loooks for configmap changes and update the run.Info.

Changes

Submitter Checklist

• [ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

• [ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

• [ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

• [ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

• [ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

• [ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

• [ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 69.56522% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.37%. Comparing base (d291f32) to head (15bc57d). Report is 3 commits behind head on main.

Files	Patch %	Lines
pkg/configutil/config.go	78.94%	2 Missing and 2 partials :warning:
pkg/adapter/adapter.go	0.00%	2 Missing :warning:
pkg/reconciler/controller.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1662 +/- ## ========================================== + Coverage 64.30% 64.37% +0.07% ========================================== Files 141 141 Lines 10922 10923 +1 ========================================== + Hits 7023 7032 +9 + Misses 3382 3376 -6 + Partials 517 515 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[chmouel]

/test go-testing

[sm43]

/test go-testing

is this a bug? no change in the icon ? and Failing status

[chmouel]

was the issue, when it failed first it didn't change the icon and kept as failed until succeeded right?

we merged some change related to that on friday cc @savitaashture

[sm43]

was the issue, when it failed first it didn't change the icon and kept as failed until succeeded right?

yes. when it was restarted using /test. the status icon didn't changed to in-progress

[chmouel]

/test go-testing

[chmouel]

it seems to work here

maybe we should get it to fail first 🤔

[sm43]

/test linters

[sm43]

same behaviour .. CI has started but no change in status icon

[sm43]

/cancel go-testing

[chmouel]

@savitaashture can you have a look ? i think it's related to this commit https://github.com/openshift-pipelines/pipelines-as-code/commit/1fe9f45d7d35eea6915471450fd6e2dd145f583a

[chmouel]

I have done some stress testing and i didn't see any crash 🍾

I did try the feature and it has been working fine:

i change the value twice and that worked (or at least from the log)

💡 06:55:36 pac-controller updating value for field MaxKeepRunsUpperLimit: from '0' to '2'
💡 06:55:46 pac-controller updating value for field MaxKeepRunsUpperLimit: from '2' to '10'

but if i delete the value and then added back after that doesn't seem to get detected

ie: if i delete max-keep-run-upper-limit and then edit and add a non default max-keep-run-upper-limit: "10" it will not detect something new (or at least there is no logging)

[sm43]

ie: if i delete max-keep-run-upper-limit and then edit and add a non default max-keep-run-upper-limit: "10" it will not detect something new (or at least there is no logging)

Yeah. it was a bug. updated the code

[chmouel]

This looks good to me, thanks a bunch cc @enarha for info..

i'll go ahead and merge and squash unless you wan tto do it ?

[savitaashture]

yes. when it was restarted using /test. the status icon didn't changed to in-progress

@sm43 can you give me the steps which you tried

I know the issue as that i made it intentionally for some reason