openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
124 stars 81 forks source link

Increase the entropy in generated PAC secrets #1663

Closed arewm closed 2 months ago

arewm commented 2 months ago

When the auth secret names only have four characters of entropy, the likelihood of collisions is high especially when there are many concurrent events triggered within a namespace.

At a minimum, we should increase the number of random characters in the secret name. If possible, this can be a configurable parameter during the deployment of PAC.

chmouel commented 2 months ago

I increased the random string to 6, i didn't make it configurable since this only make more of a burden for paac to have another knob to test/validate (k8s limitations) and supports. let me know if you have a specific use case why we should give this a setting.