codecov[bot]
commented
5 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.33%. Comparing base (
d291f32) to head (5d4eaae). Report is 2 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1664 +/- ## ========================================== + Coverage 64.30% 64.33% +0.03% ========================================== Files 141 141 Lines 10922 10922 ========================================== + Hits 7023 7027 +4 + Misses 3382 3380 -2 + Partials 517 515 -2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
we would hit some conflicts when generating the pac secrets, by increasing the entropy of 6. The secret is composed of 62 characters (26 uppercase+ 26 lowercase + 10 digits) so the total number of combinations for a string of length nn would be 62n62n.
With a length of 6 there are approximately 56.8 billion possible combinations which would not conflict anymore.
Fixes #1663
Jira: https://issues.redhat.com/browse/SRVKP-4407
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).