openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
130 stars 80 forks source link

Fix checkrun status issue #1665

Closed savitaashture closed 5 months ago

savitaashture commented 5 months ago

we encountered a bug related to status display when resolving multiple checkrun issues as part of 1566. This was rectified by introducing a new title specifix to multiple checkrun scenario.

Signed-off-by: Savita Ashture sashture@redhat.com

Screencast from 2024-04-17 14-44-46.webm

Changes

Submitter Checklist

savitaashture commented 5 months ago

fixes : https://github.com/openshift-pipelines/pipelines-as-code/pull/1662#issuecomment-2056905301

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.47%. Comparing base (755cbbd) to head (6a3f016). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1665 +/- ## ========================================== - Coverage 64.48% 64.47% -0.02% ========================================== Files 142 142 Lines 10956 10958 +2 ========================================== Hits 7065 7065 - Misses 3376 3377 +1 - Partials 515 516 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chmouel commented 5 months ago

tested as working for me,