codecov[bot]
commented
2 months ago Codecov Report
Attention: Patch coverage is 58.53659% with 51 lines in your changes are missing coverage. Please review.
Project coverage is 64.39%. Comparing base (
e8a2251) to head (e787246).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1667 +/- ## ========================================== - Coverage 64.53% 64.39% -0.15% ========================================== Files 143 143 Lines 11023 11084 +61 ========================================== + Hits 7114 7137 +23 - Misses 3388 3421 +33 - Partials 521 526 +5 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
We now have a global repository setting that can be set in the namespace where the controller is installed. This allows you to have a default setting for all repositories that don't override it.
Jira: https://issues.redhat.com/browse/SRVKP-4425 https://issues.redhat.com/browse/SRVKP-4069
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).