chmouel
commented
2 months ago /retest
Closed chmouel closed 2 months ago
chmouel
commented
2 months ago /retest
codecov[bot]
commented
2 months ago Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 64.53%. Comparing base (
44e735e) to head (ddedb1d). Report is 4 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/cmd/tknpac/info/root.go | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
move all images and binaries from pac dogfooding tekton pipelinerun to be on arm64 since we have moved our dogfooding cluster on it.
optimize cache: in order to avoid cache pollution between different images, we need to scope the cache for each image build. See documentation of that feature here:
https://docs.docker.com/build/cache/backends/gha/#scope
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).