codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.34%. Comparing base (
f9139fa) to head (b472b7a). Report is 3 commits behind head on release-v0.24.x.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## release-v0.24.x #1680 +/- ## =================================================== + Coverage 63.31% 63.34% +0.02% =================================================== Files 139 139 Lines 10746 10753 +7 =================================================== + Hits 6804 6811 +7 Misses 3418 3418 Partials 524 524 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
Backport 85a14cd73fe0a2fb765f8d13f0c6b13417e12a28 to 1.14 OSP/0.24.x branch
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).