openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
124 stars 81 forks source link

sync 'error-detection-simple-regexp' default value #1683

Closed jkandasa closed 1 month ago

jkandasa commented 1 month ago

Changes

Submitter Checklist

savitaashture commented 1 month ago

/test

chmouel commented 1 month ago

image

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.41%. Comparing base (16596b4) to head (ef987bb). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1683 +/- ## ======================================= Coverage 64.41% 64.41% ======================================= Files 143 143 Lines 11091 11091 ======================================= Hits 7144 7144 Misses 3421 3421 Partials 526 526 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jkandasa commented 1 month ago

@chmouel sorry for the test failures, please ignore. I will test it completely in local and comeback.

Ready

chmouel commented 1 month ago

I am a bit confuse about this commit i'll need to spend more time to test it manually since we don't have e2e for this error reporting (since we can't see the checks output from an API)

chmouel commented 1 month ago

tested as working!