Fix secret generation issue when GitOps comments are executed on commits

[savitaashture]

This update corrects the creation of an auto-generated secret that previously had an invalid or missing value for git-provider-token key

Fixes: https://issues.redhat.com/browse/SRVKP-4561

Signed-off-by: Savita Ashture sashture@redhat.com

Changes

Submitter Checklist

• [ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

• [ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

• [ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

• [ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

• [ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

• [ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

• [ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.54%. Comparing base (35e3307) to head (7fa45ec). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1684 +/- ## ========================================== + Coverage 64.52% 64.54% +0.01% ========================================== Files 143 143 Lines 11093 11098 +5 ========================================== + Hits 7158 7163 +5 Misses 3413 3413 Partials 522 522 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[chmouel]

i haven't tested that fix manually but the e2e test looks good,

[chmouel]

/retest

[savitaashture]

E2E Failure

{"level":"info","ts":1716789274.1189997,"caller":"test/github_pullrequest_concurrency_test.go:125","msg":"the 5 pipelineruns has successfully finished"}
    github_pullrequest_concurrency_test.go:145: assertion failed: expression is false: strings.HasPrefix(prActualName, prExpectedName): prActualName: no-match-f7jv4 does not start with expected prefix prlongrunnning-6, was is ordered properly at start time
{"level":"info","ts":1716789274.1404073,"caller":"github/pr.go:186","msg":"Closing PR 2228"}
{"level":"info","ts":1716789274.6032455,"caller":"repository/teardown.go:13","msg":"Deleting Repository in pac-e2e-ns-xmjxq"}
{"level":"info","ts":1716789274.6077428,"caller":"repository/teardown.go:16","msg":"Deleting NS pac-e2e-ns-xmjxq"}
{"level":"info","ts":1716789274.6104174,"caller":"github/pr.go:199","msg":"Deleting Ref refs/heads/pac-e2e-test-z92q4"}
--- FAIL: TestGithubSecondPullRequestConcurrency1by1 (87.47s)

Restarting to see

[savitaashture]

/test