chmouel
commented
1 month ago /retest
Closed enarha closed 1 month ago
chmouel
commented
1 month ago /retest
codecov[bot]
commented
1 month ago Attention: Patch coverage is 78.94737% with 12 lines in your changes are missing coverage. Please review.
Project coverage is 64.52%. Comparing base (
16596b4) to head (9cfd55d). Report is 5 commits behind head on main.:exclamation: Current head 9cfd55d differs from pull request most recent head a9d15cd
Please upload reports for the commit a9d15cd to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| pkg/cmd/tknpac/info/install.go | 64.70% | 4 Missing and 2 partials :warning: |
| pkg/provider/github/app/token.go | 80.64% | 4 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
enarha
commented
1 month ago generally look good, i am fine merging this but i don't know if it actually works tho (since there is no e2e tests) what is the test strategy here?(altho i understand it's kinda hard to do a e2e tests with that amount of repositories)
Apart from testing with my test app, I also did test the change with 2 other apps, one with ~130 installs and one with ~350 installs. I also tweaked the unit test to find the matching installation on the second page.
chmouel
commented
1 month ago generally look good, i am fine merging this but i don't know if it actually works tho (since there is no e2e tests) what is the test strategy here?(altho i understand it's kinda hard to do a e2e tests with that amount of repositories)
Apart from testing with my test app, I also did test the change with 2 other apps, one with ~130 installs and one with ~350 installs. I also tweaked the unit test to find the matching installation on the second page.
great, let me know about the minor refactoring and it's GTG
Changes
Fix pagignation for listing installation. Fix caching of repoList property in Install. Use the go-github ListInstallations method. Includes a workaround for cases where we fail to obtain a token for installation. If the failure happens early in the loop, we miss the legitimate installation including the matching repo.
Submitter Checklist
[x] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).