codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.
Project coverage is 64.55%. Comparing base (
225cd25) to head (a4a34ca). Report is 2 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/provider/gitlab/task.go | 57.40% | 21 Missing and 2 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1688 +/- ## ========================================== - Coverage 64.59% 64.55% -0.05% ========================================== Files 143 144 +1 Lines 11109 11161 +52 ========================================== + Hits 7176 7205 +29 - Misses 3412 3433 +21 - Partials 521 523 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
This will be using the token when fetching tasks if the fetched URL is on the same host of where the Repository URL is.
No e2e test since it involve a lot of manual setup to be able to do this, if there is more private repository features we need to test on gitlab specifically we will add that (the pac private repo feature is already tested at lenght in gitea and github providers).
Jira: https://issues.redhat.com/browse/SRVKP-4594
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).