codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 63.19%. Comparing base (
b472b7a) to head (7d026f4). Report is 1 commits behind head on release-v0.24.x.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## release-v0.24.x #1694 +/- ## =================================================== - Coverage 63.34% 63.19% -0.15% =================================================== Files 139 139 Lines 10753 10762 +9 =================================================== - Hits 6811 6801 -10 - Misses 3418 3436 +18 - Partials 524 525 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
we use sort code from k8s repo, this updates the code to the latest master but keeps using integer.IntMin to continue using golang 1.20 & check pipelinrun is not nil and its name is not empty string then only add for sorting# Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).