codecov[bot]
commented
4 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.52%. Comparing base (
9dcbe19) to head (10cf8ef). Report is 1 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1702 +/- ## ========================================== - Coverage 64.54% 64.52% -0.02% ========================================== Files 143 143 Lines 11098 11093 -5 ========================================== - Hits 7163 7158 -5 Misses 3413 3413 Partials 522 522 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
savitaashture
and do a sync.RLock while using it to make sure this don't go off the rails (altho that's should not be absolutely necessary)
https://issues.redhat.com/browse/SRVKP-5507
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).