codecov[bot]
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 83.09859% with 12 lines in your changes missing coverage. Please review.
Project coverage is 64.67%. Comparing base (
3f9bcd0) to head (c3136ec).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1703 +/- ## ========================================== + Coverage 64.59% 64.67% +0.07% ========================================== Files 144 145 +1 Lines 11151 11192 +41 ========================================== + Hits 7203 7238 +35 - Misses 3422 3426 +4 - Partials 526 528 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
chmouel
piyush-garg
This will refactor configutil to pass the validators in sync config function so that defaulting and validation can be performed separately
default validators are exposed to be used by deps
catalog parsing was broken as soon as it find the other key for same catalog so fixed that
refactored internal catalog parsing to have index data in map to convert the strut back to configmap
added utility to convert struct back to configmap to be used by deps and added unit tests
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).