openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
124 stars 81 forks source link

chore: update k8s deps #1704

Open matejvasek opened 3 weeks ago

matejvasek commented 3 weeks ago

Changes

Submitter Checklist

matejvasek commented 3 weeks ago

PTAL @vdemeester @chmouel

chmouel commented 3 weeks ago

/ok-to-test

chmouel commented 3 weeks ago

we usually do those after osp release (1.15 which comes in one or two weeks) and keep them in sync with tektoncd/pipeline k8s version do you need it now?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.59%. Comparing base (3f9bcd0) to head (ca239bb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1704 +/- ## ======================================= Coverage 64.59% 64.59% ======================================= Files 144 144 Lines 11151 11151 ======================================= Hits 7203 7203 Misses 3422 3422 Partials 526 526 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matejvasek commented 3 weeks ago

It's not urgent, but I would like to see fewer replaces as possible. It causes troubles for people using this repo as a library.

matejvasek commented 3 weeks ago

At very least I do not like seeing k8s.io/client-go v1.5.2 it is ancient version. The major version is a lie!

chmouel commented 3 weeks ago

sounds good to me but as i say we mostly follow tektoncd/pipeline but it seems they removed the replaces they had before:

https://github.com/tektoncd/pipeline/blob/main/go.mod

so we good to cleanup and remove the replace as much as possible in there (and if it compiles it's fine)

ah yeah bear in mind we need to make sure to don't break openshift-pipelines/opc as well (which is a pain to maintain when deps divergs too much between all tektoncd projects)

(probably only will be merged post 1.15.x tho)