Open matejvasek opened 3 weeks ago
PTAL @vdemeester @chmouel
/ok-to-test
we usually do those after osp release (1.15 which comes in one or two weeks) and keep them in sync with tektoncd/pipeline k8s version do you need it now?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.59%. Comparing base (
3f9bcd0
) to head (ca239bb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It's not urgent, but I would like to see fewer replaces as possible. It causes troubles for people using this repo as a library.
At very least I do not like seeing k8s.io/client-go v1.5.2
it is ancient version. The major version is a lie!
sounds good to me but as i say we mostly follow tektoncd/pipeline but it seems they removed the replaces they had before:
https://github.com/tektoncd/pipeline/blob/main/go.mod
so we good to cleanup and remove the replace as much as possible in there (and if it compiles it's fine)
ah yeah bear in mind we need to make sure to don't break openshift-pipelines/opc as well (which is a pain to maintain when deps divergs too much between all tektoncd projects)
(probably only will be merged post 1.15.x tho)
Changes
Submitter Checklist
[ ] ๐ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] โฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] โจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] ๐ If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] ๐งช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] ๐ If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] ๐ If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).