openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
124 stars 81 forks source link

Fix panic issue when concurrency is set for global repo #1715

Open savitaashture opened 2 weeks ago

savitaashture commented 2 weeks ago

The PAC watcher encounters a panic error when concurrency is set on the global repository. This PR addresses the issue by checking for nil before accessing the ConcurrencyLimit directly.

Signed-off-by: Savita Ashture sashture@redhat.com

Changes

Submitter Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.68%. Comparing base (35d7f7c) to head (fdf40db). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1715 +/- ## ========================================== + Coverage 64.67% 64.68% +0.01% ========================================== Files 145 145 Lines 11192 11196 +4 ========================================== + Hits 7238 7242 +4 Misses 3426 3426 Partials 528 528 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chmouel commented 1 week ago

Find by me but we can have a e2e test for this