zakisk
commented
1 day ago @chmouel go testing tests are failing because of replacing deprecated function with recommended.
Open zakisk opened 2 weeks ago
zakisk
commented
1 day ago @chmouel go testing tests are failing because of replacing deprecated function with recommended.
chmouel
commented
1 day ago that pr should have fix it, isnt it?
zakisk
commented
1 day ago that pr should have fix it, isnt it?
which PR?
chmouel
commented
1 day ago this PR here you just submitted, this should fix #1708 which is using a linter annotation to avoid that error, in this pr you are submitting you have removed it so it is failing, you should use the new function from the go-gitlab library to not have that error
piyush-garg
commented
1 day ago Just FYI, this new function/api is available from gitlab 16.11 https://docs.gitlab.com/ee/api/merge_requests.html#list-merge-request-diffs
This will replace deprecated GetMergeRequestChanges function to new function ListMergeRequestDiffs and related changes in unit test with respect to return types and api url changes
fix https://github.com/openshift-pipelines/pipelines-as-code/issues/1708
Signed-off-by: Zaki Shaikh zashaikh@zashaikh-thinkpadp1gen4i.bengluru.csb
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).