openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
137 stars 81 forks source link

fix: Revert GitOps event_type to pull_request #1729

Closed chmouel closed 4 months ago

chmouel commented 4 months ago

Reverted the following event types to 'pull_request':

Breaking Changes:

Deprecated:

TODO:

Fixes https://issues.redhat.com/browse/SRVKP-5775

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

Submitter Checklist

chmouel commented 4 months ago

/retest

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.64%. Comparing base (b466ac7) to head (4484a57). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1729 +/- ## ========================================== - Coverage 64.65% 64.64% -0.02% ========================================== Files 145 146 +1 Lines 11195 11265 +70 ========================================== + Hits 7238 7282 +44 - Misses 3428 3452 +24 - Partials 529 531 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

savitaashture commented 4 months ago

@chmouel can we add e2e test to verify event_type

chmouel commented 4 months ago

@savitaashture it's already there? https://github.com/openshift-pipelines/pipelines-as-code/pull/1729/files#diff-f856a475e31a6ac95f3ceaafdd87afd5dc57cde21dcc66f148663ebfc1be5be1R210

savitaashture commented 4 months ago

@savitaashture it's already there? https://github.com/openshift-pipelines/pipelines-as-code/pull/1729/files#diff-f856a475e31a6ac95f3ceaafdd87afd5dc57cde21dcc66f148663ebfc1be5be1R210

Okok sorry missed that

savitaashture commented 4 months ago

Thank you

/lgtm