Closed chmouel closed 4 months ago
/retest
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.64%. Comparing base (
b466ac7
) to head (4484a57
). Report is 10 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@chmouel can we add e2e test to verify event_type
@savitaashture it's already there? https://github.com/openshift-pipelines/pipelines-as-code/pull/1729/files#diff-f856a475e31a6ac95f3ceaafdd87afd5dc57cde21dcc66f148663ebfc1be5be1R210
Okok sorry missed that
Thank you
/lgtm
Reverted the following event types to 'pull_request':
This change restores compatibility for users relying on 'pull_request' event type for filtering GitOps comments.
Added deprecation notice in documentation for future changes to event types.
Added deprecation notice in the events stream when deprecated events comment is used.
Planned deprecation period to be determined and communicated in future updates.
Breaking Changes:
Deprecated:
TODO:
Fixes https://issues.redhat.com/browse/SRVKP-5775
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com
Submitter Checklist
[ ] ๐ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] โฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] โจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] ๐ If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] ๐งช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] ๐ If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] ๐ If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).