savitaashture
commented
1 month ago /test
Closed savitaashture closed 1 month ago
savitaashture
commented
1 month ago /test
codecov[bot]
commented
1 month ago Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
Project coverage is 65.14%. Comparing base (
7c9970d) to head (a1e40f2). Report is 2 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/pipelineascode/match.go | 0.00% | 2 Missing :warning: |
| pkg/provider/gitea/acl.go | 0.00% | 1 Missing :warning: |
| pkg/provider/github/acl.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
zakisk
commented
1 month ago @savitaashture LGTM as well.
Commit https://github.com/openshift-pipelines/pipelines-as-code/pull/1749/commits/d12f33a1bdcf800036063d6ec91b7ce7cc58b326 fixes
taskRef.bundleandpipelineRef.bundleto bundle resolver ref docCommit https://github.com/openshift-pipelines/pipelines-as-code/pull/1749/commits/9fb743dab9af91fe9bfa52d1c25ebfabd3d513ed fixes
Signed-off-by: Savita Ashture sashture@redhat.com
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).