search

openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
130 stars 80 forks source link

Add Repository and Namespace Tags to PipelineRun Count Metric #1760

Closed zakisk closed 3 weeks ago

zakisk commented 3 weeks ago

adds repository and namespace tags to pipelines_as_code_pipelinerun_count metric counter to enable filteration of PipelineRun count by repository or namespace in Pipelines as code metrics.

https://issues.redhat.com/browse/SRVKP-6217

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.10%. Comparing base (5173774) to head (807786f). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/metrics/metrics.go 62.50% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1760 +/- ## ========================================== - Coverage 65.11% 65.10% -0.01% ========================================== Files 174 174 Lines 13137 13152 +15 ========================================== + Hits 8554 8563 +9 - Misses 4018 4022 +4 - Partials 565 567 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chmouel commented 3 weeks ago

were you able to see those metrics being actually emitted and showing?

pramodbindal commented 3 weeks ago
image
chmouel commented 3 weeks ago

sounds good thanks @pramodbindal