chmouel
commented
2 months ago /retest
Closed piyush-garg closed 2 months ago
chmouel
commented
2 months ago /retest
codecov[bot]
commented
2 months ago Attention: Patch coverage is 84.17722% with 25 lines in your changes missing coverage. Please review.
Project coverage is 65.13%. Comparing base (
6f16e11) to head (9ba9da2). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/resolve/remote.go | 78.07% | 16 Missing and 9 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
savitaashture
commented
2 months ago @piyush-garg Thank you for the PR
Can you add e2e to cover the scenario which is described in this https://issues.redhat.com/browse/SRVKP-4018 and https://issues.redhat.com/browse/SRVKP-3517 which gives confidence that PR works in those cases
Will this PR covers this issue https://issues.redhat.com/browse/SRVKP-3973 ?
piyush-garg
commented
2 months ago /test
savitaashture
commented
2 months ago @piyush-garg error message
[notice] A new release of pip is available: 23.2.1 -> 24.2
[notice] To update, run: pip install --upgrade pip
3: B6 Body message is missing/retest
piyush-garg
commented
2 months ago @piyush-garg Thank you for the PR
- Can you add e2e to cover the scenario which is described in this https://issues.redhat.com/browse/SRVKP-4018 and https://issues.redhat.com/browse/SRVKP-3517 which gives confidence that PR works in those cases
- Will this PR covers this issue https://issues.redhat.com/browse/SRVKP-3973 ?
Added e2e tests for all three
piyush-garg
commented
2 months ago /test
chmouel
commented
2 months ago LGTM
tested and reviewed this and this looks good, thanks @piyush-garg
This will redesign resolver to work with multiple edge case scenarios.
Previously pac resolver was filtering pipelinerun based on annotations but it was resolving all pipelines in .tekton dir leading to resolving unnecessary pipelines and other issue was it was storing task based on task name, instead of annotation name and version, so different version of task were not used across pipelineruns in .tekton dir
Now with new design we are first filtering pipelinerun based on annotations, and then processing all pipelineruns one by one and only resolving pipeline related to these pipelineruns. Also we are now maintaining map of tasks with name and version at event level to not re fetch the task and now inline spec replacement in pipelinerun is done one by one so respective task as mentioned in annotation with name and version is used
Also before filtering the pipelineruns, we should make sure that no two pipelineruns exists with same name in .tekton dir
Added tests for the three scenarios
Submitter Checklist
[x] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[x] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[x] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[x] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[x] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).