chmouel
commented
1 month ago usually we just run vale sync command, was this updated too there?
Closed zakisk closed 1 month ago
chmouel
commented
1 month ago usually we just run vale sync command, was this updated too there?
chmouel
commented
1 month ago i don't seem to have the error, what version of vale are you using (3.7.1 here)
zakisk
commented
1 month ago @chmouel yes updating vale working on mine as well. closing this PR, thanks!
chmouel
commented
1 month ago @zakisk i think there is rule to be updated on vale sync if you want to send a PR for that
zakisk
commented
1 month ago @chmouel executed vale sync command and TermsWarnings.yml file is updated at this line and one file is added ObviousTerms.yaml, is that all you wanted in PR?
chmouel
commented
1 month ago i think it adds a new file too
but yeah we have to keep sync the rules from the official redhat rules repo
zakisk
commented
1 month ago just edited my comment :smile:
fixed regexp issue in vale config I was getting this issue locally on my machine didn't see it on any pull request and thus unable to run pre-commit hooks on locally.
Changes
Submitter Checklist
[ ] 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).