Closed zakisk closed 1 month ago
@zakisk is it possible to add e2e
Attention: Patch coverage is 0%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 64.92%. Comparing base (
316b3bc
) to head (e0c863e
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/provider/gitlab/parse_payload.go | 0.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@zakisk is it possible to add e2e
it is hard to reproduce this error, because it is intermittent. TestGitlabDeleteTagEvent was passing on my PR and on main as well but failed on nightly so we really don't know how to get that empty commits payload again on tag creation.
it happens every time in nightly job even on restart
but nonetheless fine to merge,
fixed panic in PAC controller when commits are empty in event payload on tag push hook event when tag is created in gitlab.
https://issues.redhat.com/browse/SRVKP-6695
Changes
Submitter Checklist
[ ] ๐ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
[ ] โฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
[ ] โจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
[ ] ๐ If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
[ ] ๐งช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
[ ] ๐ If feasible, please check if an end-to-end test can be added. See README for more details.
[ ] ๐ If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).