openshift-pipelines / pipelines-as-code

Pipelines-as-Code for Tekton
https://pipelinesascode.com
Apache License 2.0
137 stars 81 forks source link

Remove double check for toRef and added checks for fromRef field #1804

Closed zakisk closed 3 weeks ago

zakisk commented 3 weeks ago

removed double checks in payload validation for toRef field in bitbucker server event payload and added checks for fromRef field and added test accordingly.

Changes

Submitter Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.16%. Comparing base (549b2d8) to head (0a7143d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1804 +/- ## ========================================== + Coverage 65.08% 65.16% +0.08% ========================================== Files 175 175 Lines 13481 13487 +6 ========================================== + Hits 8774 8789 +15 + Misses 4120 4114 -6 + Partials 587 584 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chmouel commented 3 weeks ago

can you double check with manual testing ? running a PR with a .tekton dir and see if it reacts and run a /retest to see if it reacts as well

zakisk commented 3 weeks ago

@chmouel deployed controller with this PR's code and send /retest on a pull request on bitbucket server and it was working fine as it was.