Added Building Blocks to SRO

zvonkok commented 4 years ago

Using initCotnainers as validation steps
Created several building blocks for SRO
Auto rebuild of DriverContainer depending on vendor
Added wrapping of errors, for a stack of messages rather then using the go stacktrace (not helpfull in this case)

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 2 when merging fe5bc0c3c392ab8153cf1550bd64a2ffe1d661a0 into 8bdfea2a8077526a0c91136e195c83c0b1a7843d - view on LGTM.com

new alerts:

2 for Useless assignment to local variable

fixed alerts:

2 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 2 when merging 3395d39a07ef813077e5beac5a036c51ce489bc1 into 8bdfea2a8077526a0c91136e195c83c0b1a7843d - view on LGTM.com

new alerts:

2 for Useless assignment to local variable

fixed alerts:

2 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 2 when merging 277f08c6cd463709ed6554ee56702c09c52759d9 into 8bdfea2a8077526a0c91136e195c83c0b1a7843d - view on LGTM.com

new alerts:

2 for Useless assignment to local variable

fixed alerts:

2 for Useless assignment to local variable

ArangoGutierrez commented 4 years ago

/test e2e-aws

ArangoGutierrez commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

ArangoGutierrez commented 4 years ago

/test e2e-aws

ArangoGutierrez commented 4 years ago

/test all

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 2 when merging 2b1ff1d1dabf62504b2f0c8dc0ecddc11300bd0e into b9bcdca4db2fd4ffb2ab5e36c5ddfcf9f9b91325 - view on LGTM.com

new alerts:

2 for Useless assignment to local variable

fixed alerts:

2 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 2 when merging 1064304dec217180030ffc556922c7f024ff6af4 into b9bcdca4db2fd4ffb2ab5e36c5ddfcf9f9b91325 - view on LGTM.com

new alerts:

2 for Useless assignment to local variable

fixed alerts:

2 for Useless assignment to local variable

ArangoGutierrez commented 4 years ago

/retest

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 2 when merging 71195a26a275b82e2b024d2322c0dd25661f547a into b9bcdca4db2fd4ffb2ab5e36c5ddfcf9f9b91325 - view on LGTM.com

new alerts:

2 for Useless assignment to local variable

fixed alerts:

2 for Useless assignment to local variable

zvonkok commented 4 years ago

@ArangoGutierrez PTAL

ArangoGutierrez commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

openshift-psap / special-resource-operator-deprecated

Added Building Blocks to SRO #14