search

openshift-psap / special-resource-operator-deprecated

Apache License 2.0
10 stars 12 forks source link

bump golang/org/x/text version #26

Closed ArangoGutierrez closed 4 years ago

ArangoGutierrez commented 4 years ago

update go dep golang.org/x/text

CVE-2020-14040

golang.org/x/text: possibility to trigger an infinite loop in encoding/unicode could lead to crash Reported on Bug 1853652

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

kpouget commented 4 years ago

seems good to me, but I don't understand why 7 packages were removed (and prometheus/client_golang added) from go.mod, is it side-effects, or is it unrelated (and maybe should be moved to another patch)

ArangoGutierrez commented 4 years ago

seems good to me, but I don't understand why 7 packages were removed (and prometheus/client_golang added) from go.mod, is it side-effects, or is it unrelated (and maybe should be moved to another patch)

I ran a much needed go mod tidy and go mod vendor to tidy things up before committing the PR

ArangoGutierrez commented 4 years ago

/retest

kpouget commented 4 years ago

I tried to run go mod tidy / go mod vendor, but that failed on my system with this error:

go: github.com/openshift/api@v3.9.0+incompatible: reading github.com/openshift/api/go.mod at revision v3.9.0: unknown revision v3.9.0
$ go version
go version go1.14.3 linux/amd64

Carlos is having a look at it.

ArangoGutierrez commented 4 years ago

/retest

zvonkok commented 4 years ago

/lgtm /approve

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 4 years ago

/retest