search

openshift-psap / special-resource-operator-deprecated

Apache License 2.0
10 stars 12 forks source link

Bug 1853726: Out-of-tree driver with SRO implementation. #27

Closed zvonkok closed 4 years ago

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@zvonkok: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/27#issuecomment-660163325): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zvonkok commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@zvonkok: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/27#issuecomment-660163484): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 4 years ago

@zvonkok: This pull request references Bugzilla bug 1853726, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/27): >Bug 1853726: Out-of-tree driver with SRO implementation. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ArangoGutierrez commented 4 years ago

/retest

ArangoGutierrez commented 4 years ago

Pinging this here - https://www.openshift.com/blog/how-to-use-entitled-image-builds-to-build-drivercontainers-with-ubi-on-openshift

kpouget commented 4 years ago

I find it quite hard to review such a big patch; it seems that you squashed multiple patches together, maybe you could include each of the in the PR?

kpouget commented 4 years ago

Apart from the details mentioned in the comments, the patch worked well for me, the operator managed to compile the driver after installing the kernel files from the payload RPMs.

Labels:
                    beta.kubernetes.io/instance-type=p3.2xlarge
                    feature.node.kubernetes.io/kernel-version.full=4.18.0-147.8.1.el8_1.x86_64
                    feature.node.kubernetes.io/pci-10de.present=true
                    specialresource.openshift.io/device-monitoring-nvidia-gpu=ready
                    specialresource.openshift.io/device-plugin-nvidia-gpu=ready
                    specialresource.openshift.io/driver-container-nvidia-gpu=ready
                    specialresource.openshift.io/runtime-enablement-nvidia-gpu=ready
                    [...]
Capacity:
  [...]
  nvidia.com/gpu:              1

(note that is was already working before on this cluster version (OC 4.4.8))

ArangoGutierrez commented 4 years ago

/retest

ArangoGutierrez commented 4 years ago

/test images

ArangoGutierrez commented 4 years ago

test images is failing do Conflict in merge 

{"command":"git merge --no-ff 71c884d2469e9ccaf0be210bc9fb8a51db68548a","component":"clonerefs","error":"exit status 1","file":"prow/pod-utils/clone/clone.go:61","func":"k8s.io/test-infra/prow/pod-utils/clone.Run.func2","level":"info","msg":"Ran command","output":"Auto-merging vendor/modules.txt\nAuto-merging vendor/github.com/openshift/api/security/v1/zz_generated.swagger_doc_generated.go\nAuto-merging vendor/github.com/openshift/api/route/v1/zz_generated.swagger_doc_generated.go\nAuto-merging vendor/github.com/openshift/api/image/v1/zz_generated.swagger_doc_generated.go\nAuto-merging vendor/github.com/openshift/api/build/v1/zz_generated.swagger_doc_generated.go\nRemoving recipes/nvidia-vran/config/mofed-patch.json\nRemoving recipes/nvidia-vran/config/gpudirect-patch.json\nRemoving recipes/nvidia-vran/config/gdrdrv-patch.json\nRemoving recipes/nvidia-gpu/config/patch.json\nAuto-merging recipes/mlnx-rdma-shared/manifests/mofed/1000-state-driver.yaml\nAuto-merging recipes/mlnx-rdma-shared/manifests/gpudirect/1000-state-driver.yaml\nRemoving recipes/mellanox-rdma-sriov/manifests/mofed/1000-state-driver.yaml\nRemoving recipes/mellanox-rdma-sriov/manifests/mofed/0000-state-driver-buildconfig.yaml\nRemoving recipes/mellanox-rdma-sriov/manifests/gpudirect/1000-state-driver.yaml\nRemoving recipes/mellanox-rdma-sriov/config/mofed-patch.json\nRemoving recipes/mellanox-rdma-sriov/config/gpudirect-patch.json\nRemoving recipes/mellanox-rdma-sriov/config/Makefile\nRemoving recipes/mellanox-rdma-shared/manifests/mofed/0000-state-driver-buildconfig.yaml\nRemoving recipes/mellanox-rdma-shared/config/mofed-patch.json\nRemoving recipes/mellanox-rdma-shared/config/gpudirect-patch.json\nRemoving recipes/mellanox-rdma-shared/config/Makefile\nAuto-merging go.sum\nCONFLICT (content): Merge conflict in go.sum\nAuto-merging go.mod\nCONFLICT (content): Merge conflict in go.mod\nRemoving deploy/crds/sro_v1alpha1_specialresource_crd.yaml\nRemoving deploy/crds/sro_v1alpha1_specialresource_cr.yaml\nAutomatic merge failed; fix conflicts and then commit the result.\n","severity":"info","time":"2020-07-21T15:33:17Z"}
zvonkok commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@zvonkok: This pull request references Bugzilla bug 1853726, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/27#issuecomment-663105202): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zvonkok commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@zvonkok: This pull request references Bugzilla bug 1853726, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.6.0) matches configured target release for branch (4.6.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/27#issuecomment-663107880): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

openshift-ci-robot commented 4 years ago

@zvonkok: All pull requests linked via external trackers have merged: openshift-psap/special-resource-operator#27. Bugzilla bug 1853726 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/27): >Bug 1853726: Out-of-tree driver with SRO implementation. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.