search

openshift-psap / special-resource-operator-deprecated

Apache License 2.0
10 stars 12 forks source link

Adding monitoring support for SRO #39

Closed zvonkok closed 4 years ago

zvonkok commented 4 years ago

This is not well documented how to use monitoring and TLS with kube-rbac-proxy. Most of the steps in the monitoring guide are working but without kube-rbac-proxy. This setup here works also with kube-rbac-proxy.

@dagrayvid PTAL we can scrape but we need some metrics created.

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zvonkok commented 4 years ago

/uncc @Deepthidharwar /cc @ArangoGutierrez

zvonkok commented 4 years ago

@dagrayvid I am good with it. Looking in how kustomize works it would be to much editing and moving files around to make it simpler. If you're good with it then do a lgtm. So you can concentrate on the metric.

ArangoGutierrez commented 4 years ago

/retest

dagrayvid commented 4 years ago

Yes, it seems good based on the testing I did.

/lgtm