search

openshift-psap / special-resource-operator-deprecated

Apache License 2.0
10 stars 12 forks source link

Add CVO manifests #42

Closed zvonkok closed 3 years ago

zvonkok commented 3 years ago

This PR labels the Dockefile for CVO inclusion. Adds auto-generation of CVO manifests and adds image-references and ClusterOperator CR.

dagrayvid commented 3 years ago

just a nit, could you rename the files to a more descriptive name , all files are cvo-manifests/0001_specialresource_cvo_manifest.yaml 0001 to 0011....

Can we rename cvo-manifests to just manifests, to match other CVO managed operators?

dagrayvid commented 3 years ago

Thanks for the fixes. /lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, dagrayvid, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dagrayvid commented 3 years ago

/retest

dagrayvid commented 3 years ago

/retest

zvonkok commented 3 years ago

/retest

On Thu., Dec. 3, 2020, 04:26 OpenShift Merge Robot notifications@github.com wrote:

@zvonkok https://github.com/zvonkok: The following tests failed, say /retest to rerun all failed tests: Test name Commit Details Rerun command ci/prow/e2e-aws-upgrade 859e0d4 https://github.com/openshift-psap/special-resource-operator/commit/859e0d48e0ccd2518db2c588ad6f30247e2355bc link https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_special-resource-operator/42/pull-ci-openshift-psap-special-resource-operator-master-e2e-aws-upgrade/1334308755721949184 /test e2e-aws-upgrade ci/prow/e2e-aws 859e0d4 https://github.com/openshift-psap/special-resource-operator/commit/859e0d48e0ccd2518db2c588ad6f30247e2355bc link https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_special-resource-operator/42/pull-ci-openshift-psap-special-resource-operator-master-e2e-aws/1334291627996352512 /test e2e-aws

Full PR test history https://prow.ci.openshift.org/pr-history?org=openshift-psap&repo=special-resource-operator&pr=42. Your PR dashboard https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:zvonkok.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository. I understand the commands that are listed here https://go.k8s.io/bot-commands.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift-psap/special-resource-operator/pull/42#issuecomment-737641162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NPNWG57FABO3KXIUP3PDSS4AM5ANCNFSM4UK6P5IA .

ArangoGutierrez commented 3 years ago

/retest

dagrayvid commented 3 years ago

/retest

ArangoGutierrez commented 3 years ago

/retest

dagrayvid commented 3 years ago

/retest

openshift-merge-robot commented 3 years ago

@zvonkok: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 859e0d48e0ccd2518db2c588ad6f30247e2355bc link /test e2e-aws
ci/prow/e2e-aws-upgrade 859e0d48e0ccd2518db2c588ad6f30247e2355bc link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).