Open kpouget opened 1 year ago
In this PR we updated the Ansible linter, but also introduce multiple "skipped" rules (to keep the CI green).
These skipped rules should be reviewed, and decided one by one if the rule should be enforced or skipped.
Rules that are skipped:
- 'command-instead-of-module' - 'command-instead-of-shell' - 'deprecated-local-action' - 'key-order[task]' - 'jinja[spacing]' - 'no-free-form' - 'chema[meta]' - 'name[missing]' - 'var-naming[no-reserved]' - 'var-naming[no-role-prefix]' - 'var-naming[pattern]' - 'yaml[colons]' - 'yaml[commas]' - 'yaml[comments]' - 'yaml[empty-lines]' - 'yaml[indentation]' - 'yaml[key-duplicates]' - 'yaml[line-length]' - 'yaml[new-line-at-end-of-file]' - 'yaml[octal-values]' - 'yaml[trailing-spaces]' - 'yaml[truthy]' - 'name[template]' - 'name[casing]' - 'risky-file-permissions' - 'risky-shell-pipe' - 'ignore-errors' - 'no-changed-when' - 'fqcn' - 'args[module]'
rules that should be enforced, at first glance:
- command-instead-of-shell - jinja[spacing] - yaml[new-line-at-end-of-file] - risky-shell-pip - name[missing]
I think also running some bashate checks anywhere where bash/command is used will be useful
In this PR we updated the Ansible linter, but also introduce multiple "skipped" rules (to keep the CI green).
These skipped rules should be reviewed, and decided one by one if the rule should be enforced or skipped.
Rules that are skipped:
rules that should be enforced, at first glance: