openshift-psap / topsail

Test Orchestrator for Performance and Scalability of AI pLatforms
Apache License 2.0
11 stars 16 forks source link

[fine_tuning] roles: fine_tuning_run_fine_tuning_job: files/entrypoint/entrypoint: fix undefined variable #490

Closed kpouget closed 2 months ago

kpouget commented 2 months ago

@albertoperdomo2 ;-)

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from kpouget. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-psap/topsail/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kpouget commented 2 months ago

tested internally as part of this run. Merging.

albertoperdomo2 commented 2 months ago

good catch! thanks 😅