search

openshift-qe / ocp-qe-perfscale-ci

OpenShift QE PerfScale CI
Apache License 2.0
9 stars 31 forks source link

Taking out oc #630

Closed paigerube14 closed 3 months ago

paigerube14 commented 3 months ago

Want to take out oc so that the tests will install specific versions of the cli in each test

Using the Dockerfile_test (which I copied to update the Dockerfile here)

I had successful run here: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/54209/rehearse-54209-pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-gcp-4.15-nightly-arm-test/1816839020982833152 And got proper cli version 

Python 3.9.9
Client Version: 4.15.0-202407120536.p0.g1e41aa3.assembly.stream.el8-1e41aa3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Kubernetes Version: v1.28.11+add48d0
paigerube14 commented 3 months ago

/test rosa-4.17-nightly-x86-images

qiliRedHat commented 3 months ago

I think we should merge this after https://github.com/openshift/release/pull/54209

paigerube14 commented 3 months ago

@qiliRedHat I think we should merge after this one: https://github.com/openshift/release/pull/54886 It'll have the cli set and should work as expected with no other changes necessary but can should still take out the promotion parts and update only one image name

paigerube14 commented 3 months ago

/retest-required

qiliRedHat commented 3 months ago

/retest-required

paigerube14 commented 3 months ago

/test aws-4.18-nightly-x86-loaded-upgrade-from-4.17-images

paigerube14 commented 3 months ago

@qiliRedHat PTAL, the failure will need to be addressed on prow side to remove all these extra images

qiliRedHat commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paigerube14, qiliRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-qe/ocp-qe-perfscale-ci/blob/main/OWNERS)~~ [paigerube14,qiliRedHat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

paigerube14 commented 3 months ago

/test aws-4.18-nightly-x86-loaded-upgrade-from-4.17-images

paigerube14 commented 3 months ago

/retest-required

paigerube14 commented 3 months ago

/retest

paigerube14 commented 3 months ago

/retest-required

openshift-ci[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

paigerube14 commented 3 months ago

/test aws-4.14-nightly-x86-images aws-4.18-nightly-x86-loaded-upgrade-from-4.17-images

paigerube14 commented 3 months ago

/retest

paigerube14 commented 3 months ago

/retest-required

paigerube14 commented 3 months ago

/retest-required

openshift-ci[bot] commented 3 months ago

@paigerube14: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/aws-4.18-nightly-x86-loaded-upgrade-from-4.17-images 68d3e7669a77a25ed5d00b961930a1b281d35dee link true /test aws-4.18-nightly-x86-loaded-upgrade-from-4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).