search

openshift-qe / v3-testfiles

The repo to store the test files (json/yaml) which will be used during the OpenShift v3 tests. But not the place to put automation scripts
11 stars 81 forks source link

Update Deployment API version #1248

Closed duanwei33 closed 4 years ago

duanwei33 commented 4 years ago

Update Deployment API version to apps/v1.

liangxia commented 4 years ago

/hold

liangxia commented 4 years ago

Will the change affect the testing on old OCP versions ?

duanwei33 commented 4 years ago

@liangxia Thanks for the consideration. I checked the Deployment API version(I guess compatibility support should have) as below:

1.6-: extensions/v1beta1 1.6-1.9: apps/v1beta1 1.9+: apps/v1

And OCP4.1 is based on v1.13?

I guess there is low risk, of cause the safer way is changing path in .feature, it is handled by release.
What is your option?

liangxia commented 4 years ago

We also need to check the test cases which use this test file, whether it is also a 3.x test case, as test files are shared across 3.x and 4.x

duanwei33 commented 4 years ago

I checked the v3 branch, there is only one case OCP-10168 uses this file, it run on both 3.x and 4.x, OCP 3.11 is based on k8s 1.11, so I think it is acceptable.