search

openshift-roadshow / nationalparks

Backend component to display nationalparks
Apache License 2.0
44 stars 890 forks source link

Pipeline is displayed on both Dev and Live containers #7

Closed siamaksade closed 7 years ago

siamaksade commented 7 years ago

Pipeline is annotated with both Dev and Live deploymentconfigs and therefore it is displayed twice in the console:

pipeline.alpha.openshift.io/uses: '[{"name": "nationalparks-dev", "namespace": "", "kind": "DeploymentConfig"},{"name": "nationalparks-live", "namespace": "", "kind": "DeploymentConfig"}]'

pipeline

Pipeline visualization in its current form attached to either of them does not make much sense. We should probably remove the annotations and just show the pipeline in Builds → Pipelines

thoraxe commented 7 years ago

This is by design according to engineering.

The live deployment is associated with the dev deployment via the pipeline. Why would you not want to know that the live deployment has an incoming deployment associated with the pipeline?

I think it makes perfect sense. You would need to discuss with spadgett and/or jwforres to get more background. Possibly gmontero and/or bparees.

siamaksade commented 7 years ago

It looks like there are 2 pipelines being executed while that is not true. Only one pipeline is running.

thoraxe commented 7 years ago

While it looks like that, they both have the same name, the same status, and display the exact same information.

If you want to pull it, go for it. But we also need to file bugs with engineering so that the behavior works better if you think it's not clear.

siamaksade commented 7 years ago

I created an issue https://github.com/openshift/origin-web-console/issues/972

Let's add either dev or live to the annotation for now to make it display once. Otherwise, we'll have to explain this to people