search

openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Update postgresql driver to 9.4.1211 #138

Closed adrianbader closed 7 years ago

adrianbader commented 7 years ago

Update postgresql driver for every Wildfly version to 9.4.1211. ...it's my first PR; hope it works :) Thanks integrating it and rebuild/push docker image!

fixes https://github.com/openshift-s2i/s2i-wildfly/issues/137

bparees commented 7 years ago

lgtm [merge]

bparees commented 7 years ago

[merge]

bparees commented 7 years ago

[merge]

bparees commented 7 years ago

[merge]

openshift-bot commented 7 years ago

Evaluated for wildfly merge up to 30b25d39a861146f9f155f6d02012c5b1b146952

openshift-bot commented 7 years ago

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_wildfly_images/4/) (Base Commit: a1a71383b0876718de508c2dab29574f91269d21) (PR Branch Commit: 30b25d39a861146f9f155f6d02012c5b1b146952)

bparees commented 7 years ago

@dobbymoodge test pull requests is broken for this repo: https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_wildfly_images/4/console

/bin/test_pull_requests:1152:in `[]': no implicit conversion of Symbol into Integer (TypeError)
    from /bin/test_pull_requests:1152:in `block in get_comment_matching_regex'
    from /var/lib/jenkins/.gem/ruby/gems/sawyer-0.8.1/lib/sawyer/resource.rb:123:in `each'
    from /var/lib/jenkins/.gem/ruby/gems/sawyer-0.8.1/lib/sawyer/resource.rb:123:in `each'
    from /bin/test_pull_requests:1152:in `select'
    from /bin/test_pull_requests:1152:in `get_comment_matching_regex'
    from /bin/test_pull_requests:1159:in `get_comment_with_prefix'
    from /bin/test_pull_requests:967:in `test_merge_pull_request'
    from /bin/test_pull_requests:892:in `merge_pull_request'
    from /bin/test_pull_requests:2428:in `<main>'

can you take a look?

adrianbader commented 7 years ago

Hmm, I actually do not fully understand, what is going on in this test and what exactly fails...

bparees commented 7 years ago

@adrianbader it's related to our CI system, the PR itself is fine, we'll get it merged after we fix up the CI system.

bparees commented 7 years ago

[test]

openshift-bot commented 7 years ago

Evaluated for wildfly test up to 30b25d39a861146f9f155f6d02012c5b1b146952

openshift-bot commented 7 years ago

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_wildfly_images/4/) (Base Commit: a1a71383b0876718de508c2dab29574f91269d21) (PR Branch Commit: 30b25d39a861146f9f155f6d02012c5b1b146952)