search

openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Fix #163 jboss-cli local authentication does not work on OpenShift #164

Closed ppalaga closed 6 years ago

openshift-ci-robot commented 6 years ago

Hi @ppalaga. Thanks for your PR.

I'm waiting for a openshift or openshift-s2i member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ppalaga commented 6 years ago

/assign @bparees

bparees commented 6 years ago

thanks @ppalaga

/lgtm

openshift-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-s2i/s2i-wildfly/blob/master/OWNERS)~~ [bparees] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bparees commented 6 years ago

/ok-to-test

0xmichalis commented 6 years ago

@bparees @stevekuznetsov openshift-merge-robot is not authorized to merge PRs in this repo.

{"base-sha":"152b269d8b9b448f034bc6db1a92e139c0b5cdfd","branch":"master","component":"tide","controller":"sync","error":"You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.","level":"error","msg":"Merge failed: PR is unmergable. How did it pass tests?!","org":"openshift-s2i","pr":164,"repo":"s2i-wildfly","sha":"d5cadfc6f8f4b59947dfd0187f2d97d384fbf577","time":"2018-03-28T10:52:20Z"}
bparees commented 6 years ago

@kargakis merge-bot and ci-bot are both listed as collaborators w/ write access.

Since we have branch protection on, perhaps something additional is needed, but it's the same setup we have in our other repos?

bparees commented 6 years ago

ok I may have fixed it.

/retest

bparees commented 6 years ago

/lgtm cancel

bparees commented 6 years ago

i guess i did. :)

thanks @kargakis