search

openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Updated to reflect the actual location of modules. #167

Closed weltonrodrigo closed 6 years ago

weltonrodrigo commented 6 years ago

assemble copies modules not from provided_modules, but from modules.

This was introduced here: https://github.com/weltonrodrigo/s2i-wildfly/commit/79881a8f96ab44a14b1431352344f87147080b7b#diff-86b6cd13190bafd3993e8bf3db0c1945R340

openshift-ci-robot commented 6 years ago

Hi @weltonrodrigo. Thanks for your PR.

I'm waiting for a openshift or openshift-s2i member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bparees commented 6 years ago

/ok-to-test /lgtm /approve

thanks @weltonrodrigo

openshift-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-s2i/s2i-wildfly/blob/master/OWNERS)~~ [bparees] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment