search

openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Add adambkaplan as approver #183

Closed adambkaplan closed 5 years ago

adambkaplan commented 5 years ago

/assign @bparees

bparees commented 5 years ago

/lgtm

bparees commented 5 years ago

/approve

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-s2i/s2i-wildfly/blob/master/OWNERS)~~ [bparees] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bparees commented 5 years ago

/retest

adambkaplan commented 5 years ago

@bparees looks like Travis isn't fast-forwarding on top of master, still using golang 1.9

bparees commented 5 years ago

yeah i think that's true...one of the limitations of travis. i'll manually merge this and the other PR since they passed.