openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Upgrade travis golang to 1.10 #184

Closed adambkaplan closed 5 years ago

adambkaplan commented 5 years ago

Required for latest s2i changes.

/assign @bparees

bparees commented 5 years ago
$ hack/build-go.sh
++ Building go targets for linux/amd64: cmd/s2i
flag provided but not defined: -pkgdir
usage: install [build flags] [packages]
bparees commented 5 years ago
$ go version
go version go1.1 linux/amd64
go.env
$ go env
GOARCH="amd64"
GOBIN=""
GOCHAR="6"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/travis/gopath"
GORACE=""
GOROOT="/home/travis/.gimme/versions/go1.1.src"
GOTOOLDIR="/home/travis/.gimme/versions/go1.1.src/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-g -O2 -fPIC -m64 -pthread"
CGO_ENABLED="1"
before_install.1
0.00s$ pushd /tmp
/tmp ~/gopath/src/github.com/openshift-s2i/s2i-wildfly
before_install.2
2.52s$ git clone https://github.com/openshift/source-to-image source-to-image
Cloning into 'source-to-image'...
remote: Enumerating objects: 23, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 25064 (delta 3), reused 15 (delta 3), pack-reused 25041
Receiving objects: 100% (25064/25064), 22.73 MiB | 20.93 MiB/s, done.
Resolving deltas: 100% (10211/10211), done.
before_install.3
0.00s$ cd source-to-image
0.33s$ hack/build-go.sh
++ Building go targets for linux/amd64: cmd/s2i
flag provided but not defined: -pkgdir
usage: install [build flags] [packages]
bparees commented 5 years ago

looks like you got golang v1.1 somehow....

adambkaplan commented 5 years ago

uggh YAML - think it parsed 1.10 to the number 1.1. Should be fixed now.

bparees commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-s2i/s2i-wildfly/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment