search

openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Add WildFly 16.0.0.Final #185

Closed jamesnetherton closed 5 years ago

openshift-ci-robot commented 5 years ago

Hi @jamesnetherton. Thanks for your PR.

I'm waiting for a openshift-s2i or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bparees commented 5 years ago

/assign @adambkaplan

bparees commented 5 years ago

/ok-to-test

bparees commented 5 years ago

@adambkaplan let me know when you're happy w/ this one and i'll manually merge it over the travis failure.

adambkaplan commented 5 years ago

/approve

jamesnetherton commented 5 years ago

Pushed 29fc38e2eb7a838d7b44bbfffafe4287ef00b7b6 which addresses those few nits.

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, jamesnetherton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-s2i/s2i-wildfly/blob/master/OWNERS)~~ [adambkaplan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment