openshift-s2i / s2i-wildfly

Source-to-Image template for WildFly applications
http://wildfly.org/
Other
73 stars 145 forks source link

Use Pod IP address for the public interface #188

Closed jmesnil closed 5 years ago

jmesnil commented 5 years ago

Use hostname -i to determine the IP address of the Pod and bind the WildFly public interface to it.

Do not bind jgroups.bind_address to 0.0.0.0 (that is incorrect for JGroups). Instead, if JGroups subsystem is defined, the standalone configuration can attach its socket-binding to the public interface so that the Pod IP addres is properly used to identiy JGroups nodes.

openshift-ci-robot commented 5 years ago

Hi @jmesnil. Thanks for your PR.

I'm waiting for a openshift-s2i or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
bparees commented 5 years ago

/lgtm

bparees commented 5 years ago

/ok-to-test /approve

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jmesnil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-s2i/s2i-wildfly/blob/master/OWNERS)~~ [bparees] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmesnil commented 5 years ago

@bparees thanks. When do you plan to push the openshift/wildfly-160-centos7 Docker image with that fix?

bparees commented 5 years ago

@jmesnil normally it happens automatically on merge. It looks like our push job failed and for some reason I did not see a jenkins email from the job. I'll rekick it.

/cc @adambkaplan

bparees commented 5 years ago

failed job: https://ci.openshift.redhat.com/jenkins/job/push_wildfly_images/78/

rekick: https://ci.openshift.redhat.com/jenkins/job/push_wildfly_images/79/

bparees commented 5 years ago

new image is up now: https://hub.docker.com/r/openshift/wildfly-160-centos7/tags

jmesnil commented 5 years ago

thanks!