search

openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

Fix downstream container builds #1152

Closed jmontleon closed 5 years ago

jmontleon commented 5 years ago

Files are always added to the container owned as root.

When the users group is properly set the commands aren't run with the root group and fail. The upstream image is running commands as ansible-operator:root rather than ansible-operator:ansible-operator so it doesn't see this.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 40.97% when pulling f7d49b9c7f529bf08590a5bdf1461864aa5a2526 on jmontleon:fix-downstream-builsd into bfc4f26697e8630508866ec3180730bf6281ad66 on openshift:master.

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djzager, jmontleon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [djzager,jmontleon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment