Add Dockerfile link to prepare for automated downstream builds

openshift / ansible-service-broker

Ansible Service Broker

Apache License 2.0

226 stars 84 forks source link

Add Dockerfile link to prepare for automated downstream builds #1154

Closed jmontleon closed 5 years ago

jmontleon commented 5 years ago

My understanding is the Dockerfile for downstream OCP builds must exist in the build context directory. Essentially what is run is, "docker build -f $DIR/$DOCKERFILE $DIR".

As far as I know it can be a link. If for some reason it can't I can PR a swap of the file and link.

coveralls commented 5 years ago

Coverage remained the same at 40.97% when pulling 387e0df943e59cba2e9ba6a3605fff12608b11cc on jmontleon:prepare-art-builds into 339edf6314a8112b3b8c074ba82ebac9f8ee81a5 on openshift:master.

djzager commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djzager, jmontleon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [djzager,jmontleon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-bot commented 5 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.