Add OLM support to new operator

openshift / ansible-service-broker

Ansible Service Broker

Apache License 2.0

226 stars 84 forks source link

Add OLM support to new operator #1169

Closed eriknelson closed 5 years ago

eriknelson commented 5 years ago

Describe what this PR does and why we need it:

This PR continues #1166, adding requirements for deployment via OLM. The key differences between this and the previous operator is:

APB support has been dropped, in favor of a role that is specifically designed for ansible operator.
The operator's ansible is responsible for provisioning the application's SA and RBAC, rather than delegating this to OLM.
The public interface has been simplified with the expectation that users will express their configuration via a limited set of values in their CRs. Legacy operating modes such as basic auth and an etcd based dao have been deprecated.

coveralls commented 5 years ago

Coverage remained the same at 40.97% when pulling bb46fb58ad8346c8cb161eb33bbefbe2a009de94 on eriknelson:op2-olm into d47dc0fe5897ac8708703418206884df6bf5f04d on openshift:master.

djzager commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djzager, eriknelson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [djzager,eriknelson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment