search

openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

adding OLM testing file #1187

Closed shawn-hurley closed 5 years ago

shawn-hurley commented 5 years ago

Describe what this PR does and why we need it:

This adds a docker file, that will allow you to use the downstream CSV for an OLM install while changing the images that it creates. You will need to create a new container image and deploy this into the cluster.

To use this Dockerfile:

  1. create a new image from the operator directory. Exmaple: $ docker build -t quay.io/shawn_hurley/testing-downstream-catalog-source -f build/olm-testing.Dockerfile --build-arg operator_name=quay.io/shawn_hurley/abo:v4.0 --build-arg broker_name=quay.io/shawn_hurley/ab:v4.0 .

  2. Run this image as a catalog source by creating this resource:

    apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: abo-registry
namespace: openshift-operator-lifecycle-manager
spec:
sourceType: grpc
image: quay.io/shawn_hurley/testing-downstream-catalog-source

Then follow the same UI steps to install the automation-broker-operator and automation-broker which should use the images that you changed.

NOTE: This is only for testing.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 40.97% when pulling 0744b8e667e025e919a5af537d136404324d36a0 on shawn-hurley:bugfix/add-olm-testing-registry into dfd12196faf8c347f3d499d3fd0e9202709fb46b on openshift:master.

shawn-hurley commented 5 years ago

@jmrodri alpine is just used as a builder, the image that it ends up is the second from: quay.io/openshift/origin-operator-registry:latest

which is acceptable, hope that helps explain things.

shawn-hurley commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

@shawn-hurley: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/ansible-service-broker/pull/1187#issuecomment-469416135): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jmrodri commented 5 years ago

/lgtm this should appease the bots

jmrodri commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/master/OWNERS)~~ [jmrodri,shawn-hurley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment