search

openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

Bug 1678158 - backport oauth2 support to rhcc #1194

Closed jmrodri closed 5 years ago

jmrodri commented 5 years ago
jmrodri commented 5 years ago

Before the patch

...
[2019-03-19T15:29:32.623Z] [INFO] - Attempting bootstrap...
[2019-03-19T15:29:32.623Z] [INFO] - AnsibleBroker::Bootstrap
[2019-03-19T15:29:32.623Z] [DEBUG] - Dao::BatchGetRaw
[2019-03-19T15:29:32.624Z] [DEBUG] - Successfully loaded [ 0 ] objects from etcd dir [ /spec ]
[2019-03-19T15:29:32.788Z] [DEBUG] - RHCCRegistry::LoadImages
[2019-03-19T15:29:32.788Z] [DEBUG] - Using https://registry.access.stage.redhat.com/v1/search?q=%22%2A-apb%22 to source APB images
[2019-03-19T15:29:32.943Z] [ERROR] - unable to retrieve image names for registry rh - Get https://registry.access.stage.redhat.com/v1/search?q=%22%2A-apb%22: x509: certificate signed by unknown authority
[2019-03-19T15:29:32.943Z] [WARNING] - registry: 0x13f5930 was unable to complete bootstrap - Get https://registry.access.stage.redhat.com/v1/search?q=%22%2A-apb%22: x509: certificate signed by unknown authority
[2019-03-19T15:29:32.943Z] [ERROR] - Failed to bootstrap on startup!
[2019-03-19T15:29:32.943Z] [ERROR] - all registries failed on bootstrap
jmrodri commented 5 years ago

After the patch

...
[2019-03-19T20:22:49.349Z] [INFO] - == REGISTRY CX == 
[2019-03-19T20:22:49.349Z] [INFO] - Name: rh
[2019-03-19T20:22:49.349Z] [INFO] - Type: rhcc
[2019-03-19T20:22:49.349Z] [INFO] - Url: https://registry.access.stage.redhat.com
[2019-03-19T20:22:49.349Z] [WARNING] - skipping verification of registry TLS certificate per adapter configuration
[2019-03-19T20:22:49.349Z] [DEBUG] - Creating filter for registry: rh
[2019-03-19T20:22:49.349Z] [DEBUG] - whitelist: [.*-apb$]
[2019-03-19T20:22:49.349Z] [DEBUG] - blacklist: []
...
[2019-03-19T20:22:49.805Z] [DEBUG] - GET /v2/ successful without token
[2019-03-19T20:22:49.805Z] [DEBUG] - RHCCRegistry::LoadImages
[2019-03-19T20:22:49.805Z] [DEBUG] - Using https://registry.access.stage.redhat.com/v1/search?q=%22%2A-apb%22 to source APB images
[2019-03-19T20:22:50.312Z] [DEBUG] - Properly unmarshalled image response
[2019-03-19T20:22:50.312Z] [DEBUG] - Filter applied against registry: rh
[2019-03-19T20:22:50.313Z] [DEBUG] - APBs passing white/blacklist filter:
[2019-03-19T20:22:50.313Z] [DEBUG] - -> rhpam-7/rhpam-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> openshift3/mariadb-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> codeready-workspaces-beta/server-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> openshift3/automation-broker-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> openshift3/mediawiki-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> cnv-tech-preview/kubevirt-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> rhv4-tech-preview/ovirt-flexvolume-driver-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> cnv-tech-preview/import-vm-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> openshift3/mysql-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - -> openshift3/postgresql-apb
[2019-03-19T20:22:50.313Z] [DEBUG] - RHCCAdapter::FetchSpecs
...
[2019-03-19T20:22:50.711Z] [DEBUG] - openshift3/mariadb-apb
[2019-03-19T20:22:50.711Z] [DEBUG] - RHCCAdapter::LoadSpec
[2019-03-19T20:22:50.711Z] [DEBUG] - Registry::imageToSpec
[2019-03-19T20:22:50.991Z] [DEBUG] - adapter::imageToSpec -> Got plans [{ID: Name:dev Description:This plan deploys a single MariaDB ...
...
[2019-03-19T20:22:53.293Z] [DEBUG] - Successfully converted Image registry.access.stage.redhat.com/openshift3/postgresql-apb:v3.9.68 into Spec
[2019-03-19T20:22:53.293Z] [INFO] - Validating specs...
[2019-03-19T20:22:53.293Z] [NOTICE] - All specs passed validation!
[2019-03-19T20:22:53.344Z] [NOTICE] - Broker successfully bootstrapped on startup
[2019-03-19T20:22:53.344Z] [DEBUG] - RefreshInterval: 10m0s
[2019-03-19T20:22:53.344Z] [DEBUG] - calling NewSecureServingOptions
[2019-03-19T20:22:53.458Z] [DEBUG] - Creating k8s apiserver
[2019-03-19T20:22:53.459Z] [DEBUG] - Unable to get broker.cluster_url from config
[2019-03-19T20:22:53.46Z] [NOTICE] - Listening on https://[::]:1338
[2019-03-19T20:22:53.46Z] [NOTICE] - Ansible Service Broker Starting
coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 31.47% when pulling 0c4b40abf12e352e3c0f92eddce54709f962e555 on 3.9-skip-verify-tls into 6a05b724528930d323fac495db438115ca84ed88 on release-1.1.

shawn-hurley commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ansible-service-broker/blob/release-1.1/OWNERS)~~ [jmrodri,shawn-hurley] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment