openshift / ansible-service-broker

Ansible Service Broker
Apache License 2.0
226 stars 84 forks source link

Update Dockerfile-openshift #1203

Closed sosiouxme closed 5 years ago

sosiouxme commented 5 years ago

This needs to be usable from both OKD and OCP. OKD now should have same RPM sources as OCP so this should work.

@jmontleon @stevekuznetsov -- discuss?

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sosiouxme To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: jmontleon

If they are not already assigned, you can assign the PR to them by writing /assign @jmontleon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/ansible-service-broker/blob/release-4.0/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shawn-hurley commented 5 years ago

/hold

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 40.97% when pulling 8d4a899046aa2842f7152a60529047291bfa8736 on sosiouxme-patch-1 into 8d90915130b7c7c5eb4131529c7440df8259e44e on release-4.0.

shawn-hurley commented 5 years ago

/retest

sosiouxme commented 5 years ago

The composes got updated today and also a bug in the repo sync was fixed so hopefully all necessary RPM content is now available for building. We're not really building 4.0 any more though so perhaps this should move to master or 4.1 branch? Up to you how best to proceed.

sosiouxme commented 5 years ago

/retest

stevekuznetsov commented 5 years ago

/retest

sosiouxme commented 5 years ago

prow / cluster weirdness /retest

shawn-hurley commented 5 years ago

No package openshift-clients available

@sosiouxme

sosiouxme commented 5 years ago

yeah, noticed that.

@stevekuznetsov sorry I'm not familiar enough with the CI config to know how repos get configured in... any idea why openshift-clients RPM isn't available to this build? We definitely sync that out in the rhel-server-ose-rpms repo.

alternatively, should we consider just basing the image on ose-cli to get the client?

smarterclayton commented 5 years ago

Base on cli if you want the CLI binary.

openshift-ci-robot commented 5 years ago

@sosiouxme: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/operator-molecule-olm-e2e c89ac9d0c09c44421d64982545d3d97190d54633 link /test operator-molecule-olm-e2e
ci/prow/operator-lint 8d4a899046aa2842f7152a60529047291bfa8736 link /test operator-lint
ci/prow/images 8d4a899046aa2842f7152a60529047291bfa8736 link /test images
ci/prow/operator-molecule-e2e 8d4a899046aa2842f7152a60529047291bfa8736 link /test operator-molecule-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sosiouxme commented 5 years ago

No package ansible-service-broker-container-scripts available. Thanks, yum, that would have been nice to know back when openshift-clients was listed as unavailable. So. Why aren't the RPMs that OCP builds and syncs to AWS... available for image builds? @shawn-hurley could the remaining RPMs be omitted in favor of building from source in the container?

jmrodri commented 5 years ago

@sosiouxme @shawn-hurley do we still need this PR?

sosiouxme commented 5 years ago

@jmrodri obviously not on release-4.0, will reopen on master when it becomes a priority again.